Add samsungtv zeroconf discovery#47715
Conversation
This reverts commit 3f8b9ee.
| } | ||
| }, | ||
| "abort": { | ||
| "already_in_progress": "Samsung TV configuration is already in progress.", |
There was a problem hiding this comment.
You could use even more global translations: https://github.com/djpremier/core/blob/a73daa5f20a2c51cbba94223a682e795302929fb/homeassistant/strings.json#L60
There was a problem hiding this comment.
Welcome @escoand !
I would love if you would finalize it, after all is your work ;-)
| self._title = self._name | ||
|
|
||
| result = await self.hass.async_add_executor_job(self._try_connect) | ||
| await self._abort_if_already_configured() |
There was a problem hiding this comment.
You can only call this if you have set a unique ID. But that's not the case when the user instantiates this flow at this point.
| await self._abort_if_already_configured() | ||
|
|
||
| await self.hass.async_add_executor_job(self._try_connect) | ||
| await self._get_and_check_device_info() |
There was a problem hiding this comment.
Could you set the unique ID after you get the device info?
There was a problem hiding this comment.
Unique id call added
|
I had a long time mess on my core fork. Seems I cannot anymore "claim" this PR. Sorry for the trouble :-( Simone |
|
Here the final code: chemelli74:chemelli74-samsungtv Simone |
|
Open a new PR and include a link to this PR in the PR description. We can't recover it either. |
|
Tag me when you open the PR so I can finish reviewing. |
4 participants
Proposed change
Add samsungtv zeroconf discovery from @escoand (see initial PR #35773)
Code confirmed to be working for me and @pergolafabio.
Just need a fixed/reserved ip.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: